Repository navigation
Use Node.js 26 and pnpm 12 with Aurora 1.0.0-alpha.20 - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aurora moved to Node.js 26 (plone/aurora#293) and pnpm 12 (plone/aurora#294), both released in 1.0.0-alpha.20. This PR moves the images over too.
Change
aurora-builderandaurora-prod-configbuild fromnode:26-bookworm-sliminstead ofnode:24-bookworm-slim. The matching comments in.hadolint.yamlandrelease.ymlare updated. Node.js 26 no longer bundles corepack, but the images already install it with npm.version.txtgoes from alpha.19 to alpha.20. pnpm 12 needs alpha.20, because alpha.19 writes@plone/typesasworkspace: *in@plone/clientand pnpm 12 rejects that.COOKIEPLONE_REPOSITORY_TAGmoves to the merge commit of Use pnpm 12.14.0 in the Aurora templates cookieplone-templates#495. That commit includes:packageManagerof the generated project topnpm@12.14.0.corepack installonly caches the launcher, and corepack downloaded the binary the first timepnpmran, so every new container fetched it on start.pnpm/Dockerfilenow runspnpm --versionduring the build, so the binary is already in the image.Checks
Run locally on linux/arm64:
make lintpasses.make build-imagesbuilds the builder, dev, prod-config and main images.package.json, so corepack resolves the latest pnpm there, as before.react-router-servelistens, and the healthcheck reports healthy.pnpmdoesn't download anything when the container starts.GET /returns 500. I didn't compare this against the current images.The amd64 builds only run in CI.